lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 01/13] ecryptfs: add missing lock around notify_change
In message <20080424114008.353519557@szeredi.hu>, Miklos Szeredi writes:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> Caller of notify_change() need to hold i_mutex.
>
> Compile tested only.
>
> Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
> ---
> fs/ecryptfs/inode.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: vfs-2.6/fs/ecryptfs/inode.c
> ===================================================================
> --- vfs-2.6.orig/fs/ecryptfs/inode.c 2008-04-02 18:47:17.000000000 +0200
> +++ vfs-2.6/fs/ecryptfs/inode.c 2008-04-02 18:49:18.000000000 +0200
> @@ -908,7 +908,9 @@ static int ecryptfs_setattr(struct dentr
> if (ia->ia_valid & (ATTR_KILL_SUID | ATTR_KILL_SGID))
> ia->ia_valid &= ~ATTR_MODE;
>
> + mutex_lock(&lower_dentry->d_inode->i_mutex);
> rc = notify_change(lower_dentry, ia);
> + mutex_unlock(&lower_dentry->d_inode->i_mutex);
> out:
> fsstack_copy_attr_all(inode, lower_inode, NULL);
> return rc;

Mike/Miklos,

Why is this patch part of the r/o bind mount 13-part patchset? It seems to
me that this could go to akpm/Linus right now (w/o waiting for r/o bind
mount debate to conclude).

Ditto for the next one: [patch 02/13] ecryptfs: clean up (un)lock_parent

Thanks,
Erez.


\
 
 \ /
  Last update: 2008-04-24 19:05    [W:0.130 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site