Messages in this thread Patch in this message | | | Subject | Re: physmap and "request_module: runaway loop modprobe net-pf-1" | From | David Woodhouse <> | Date | Thu, 24 Apr 2008 06:49:03 +0100 |
| |
On Wed, 2008-04-23 at 22:01 -0600, Gordon Farquharson wrote: > I guess the question is which patch (if either) is more appealing.
I definitely think we should initialise AF_UNIX sockets earlier. At least request_module() _can_ work then, if you want it to and you set up userspace accordingly.
I'm also tempted to reduce the proliferation of modules in drivers/mtd and turn the various partition options into booleans, though. Your original patch is close, but I don't think it works in the CONFIG_MTD=m case. I think we need to modify drivers/mtd/Makefile too, along these lines:
diff --git a/drivers/mtd/Makefile b/drivers/mtd/Makefile index 4b77335..6137eec 100644 --- a/drivers/mtd/Makefile +++ b/drivers/mtd/Makefile @@ -7,12 +7,12 @@ obj-$(CONFIG_MTD) += mtd.o mtd-y := mtdcore.o mtdsuper.o mtd-$(CONFIG_MTD_PARTITIONS) += mtdpart.o -obj-$(CONFIG_MTD_CONCAT) += mtdconcat.o -obj-$(CONFIG_MTD_REDBOOT_PARTS) += redboot.o -obj-$(CONFIG_MTD_CMDLINE_PARTS) += cmdlinepart.o -obj-$(CONFIG_MTD_AFS_PARTS) += afs.o -obj-$(CONFIG_MTD_AR7_PARTS) += ar7part.o -obj-$(CONFIG_MTD_OF_PARTS) += ofpart.o +mtd-$(CONFIG_MTD_CONCAT) += mtdconcat.o +mtd-$(CONFIG_MTD_REDBOOT_PARTS) += redboot.o +mtd-$(CONFIG_MTD_CMDLINE_PARTS) += cmdlinepart.o +mtd-$(CONFIG_MTD_AFS_PARTS) += afs.o +mtd-$(CONFIG_MTD_AR7_PARTS) += ar7part.o +mtd-$(CONFIG_MTD_OF_PARTS) += ofpart.o # 'Users' - code which presents functionality to userspace. obj-$(CONFIG_MTD_CHAR) += mtdchar.o
I'll play with it.
-- dwmw2
| |