lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 00/13] vfs: add helpers to check r/o bind mounts
On Thu, Apr 24, 2008 at 05:18:12PM +0200, Miklos Szeredi wrote:

> > Oh, for fuck sake... grep and ye shall see. Right next to setattr we
> > have nfsd4_set_nfs4_acl(), with pair of set_nfsv4_acl_one(). I'd rather
> > have those two covered by a single will/wont range, TYVM.
> >
> > nfsd_create() will happily do vfs_mkdir() and nfsd_create_setattr(). Ditto.
>
> Please read the patches? I've left exactly these
> mnt_want_write/drop_write() calls in place, and removed all the
> others.

You've left _what_ in place? nfsd4_set_nfs4_acl() currently doesn't have
that single range - fh_verify() + set_nvfs4_acl_one() + set_nfsv4_acl_one().
And AFAICS you do nothing of that kind there.


\
 
 \ /
  Last update: 2008-04-24 17:41    [W:0.401 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site