Messages in this thread | | | Date | Thu, 24 Apr 2008 16:38:29 +0100 | From | Al Viro <> | Subject | Re: [patch 00/13] vfs: add helpers to check r/o bind mounts |
| |
On Thu, Apr 24, 2008 at 05:18:12PM +0200, Miklos Szeredi wrote:
> > Oh, for fuck sake... grep and ye shall see. Right next to setattr we > > have nfsd4_set_nfs4_acl(), with pair of set_nfsv4_acl_one(). I'd rather > > have those two covered by a single will/wont range, TYVM. > > > > nfsd_create() will happily do vfs_mkdir() and nfsd_create_setattr(). Ditto. > > Please read the patches? I've left exactly these > mnt_want_write/drop_write() calls in place, and removed all the > others.
You've left _what_ in place? nfsd4_set_nfs4_acl() currently doesn't have that single range - fh_verify() + set_nvfs4_acl_one() + set_nfsv4_acl_one(). And AFAICS you do nothing of that kind there.
| |