lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 00/13] vfs: add helpers to check r/o bind mounts
From
Date
> > > RTFS.  permission() doesn't do "is that vfsmount read-only" checks, exactly
> > > because it's 100% bogus - either you cover it with entire area where we
> > > are guaranteed to stay r/w, or it's by definition racy.
> >
> > I know that.
> >
> > That does not mean, that fh_verify() needs to do vfsmount r/o checks.
> > AFAICS it's perfectly OK to do that later, around the vfs_ call.
>
> ... and around everything else that happens to be done after fh_verify
> for write access, surely?

What in particular? You have managed to avoid answering this question
for the last...I don't know how many emails.

> Note that e.g. nfsd_setattr() does _not_ call
> vfs_<anything>()...

Yes it does: notify_change(). It's vfs_setattr() under a pseudonym.

Miklos


\
 
 \ /
  Last update: 2008-04-24 16:57    [W:0.107 / U:1.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site