lkml.org 
[lkml]   [2008]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Colibri: Fix support for DM9000 ethernet device.
On Thu, 24 Apr 2008, Ben Dooks wrote:
> On Thu, Apr 24, 2008 at 10:13:09AM +0000, Michael Abbott wrote:
>> From: Michael Abbott <michael.abbott@diamond.ac.uk>
>>
>> Colibri: Fix support for DM9000 ethernet device.
>> diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c
>> --- a/arch/arm/mach-pxa/colibri.c
>> +++ b/arch/arm/mach-pxa/colibri.c
>> @@ -118,7 +118,7 @@ static void __init colibri_init(void)
>> /* DM9000 LAN */
>> pxa_gpio_mode(GPIO78_nCS_2_MD);
>> pxa_gpio_mode(GPIO_DM9000 | GPIO_IN);
>> - set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING);
>> + set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);
>
> The set_irq_type() call here should be removed.

I can confirm that Ben is right, and that the set_irq_type call can be
removed.

What is the procedure here? Do I submit a new patch to supersede the old
one?


\
 
 \ /
  Last update: 2008-04-24 14:27    [W:0.066 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site