Messages in this thread Patch in this message | | | Date | Thu, 24 Apr 2008 12:28:58 +0100 | From | Ben Dooks <> | Subject | Re: [PATCH] Colibri: Fix support for DM9000 ethernet device. |
| |
On Thu, Apr 24, 2008 at 10:13:09AM +0000, Michael Abbott wrote: > From: Michael Abbott <michael.abbott@diamond.ac.uk> > > Colibri: Fix support for DM9000 ethernet device. > > Two changes are necessary to enable proper operation of the DM9000 device > with the Colibri PXA 270 board: firstly, the IRQ type needs to be > configured for rising edge interrupts, and secondly this configuration needs > to be communicated through to the DM9000. > > Signed-off-by: Michael Abbott <michael.abbott@diamond.ac.uk> > --- > arch/arm/mach-pxa/colibri.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > Patch applied against v2.6.25 > > Proper operation of this device also depends on the DM9000 timer patch > submitted separately. > > diff --git a/arch/arm/mach-pxa/colibri.c b/arch/arm/mach-pxa/colibri.c > index 6db54e3..a76f95a 100644 > --- a/arch/arm/mach-pxa/colibri.c > +++ b/arch/arm/mach-pxa/colibri.c > @@ -97,7 +97,7 @@ static struct resource dm9000_resources[] = { > [2] = { > .start = COLIBRI_ETH_IRQ, > .end = COLIBRI_ETH_IRQ, > - .flags = IORESOURCE_IRQ, > + .flags = IORESOURCE_IRQ | IRQF_TRIGGER_RISING, > }, > }; > > @@ -118,7 +118,7 @@ static void __init colibri_init(void) > /* DM9000 LAN */ > pxa_gpio_mode(GPIO78_nCS_2_MD); > pxa_gpio_mode(GPIO_DM9000 | GPIO_IN); > - set_irq_type(COLIBRI_ETH_IRQ, IRQT_FALLING); > + set_irq_type(COLIBRI_ETH_IRQ, IRQT_RISING);
The set_irq_type() call here should be removed.
-- Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
| |