Messages in this thread | | | Date | Wed, 23 Apr 2008 23:03:31 -0400 | From | Michael Krufky <> | Subject | Re: [PATCH] Fix VIDIOCGAP corruption in ivtv |
| |
Mauro Carvalho Chehab wrote: >>>> Signed-off-by: Michael Krufky <mkrufky@linuxtv.org> >>> >>> In this case, it should be reviewed-by. >>> >>> I should be sending this soon to Linus. >> >> >> Mauro, >> >> I think it's wrong that you alter signatures. You did this: >> >> Reviewed-by: <mkrufky@linuxtv.org <mailto:mkrufky@linuxtv.org>> > > Argh! I didn't notice that weird stuff. This should be fixed before > forwarding the patch. Sorry for the mess. > > [snip] > > After the merge at mainstream, you'll send this to stable. In this > case, you'll take it from my tree, add your SOB, and forward it. > > Unfortunately, it is a common mistake of people sending SOB's instead > of acked-by or reviewed-by, so several maintainers warns about the > improper usage of the tags and corrects it on their trees, or simply > ignores such improper usage.
Good point. > > If you prefer, I may just drop the tag from my tree, or fix the > "reviewed-by".
Perhaps it makes most sense to just drop my tag, in this case -- that's fine with me.
Regards,
Mike
| |