Messages in this thread | | | Date | Thu, 24 Apr 2008 01:16:09 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH v2] asic3: platform_get_irq() may return signed unnoticed |
| |
On Thu, Apr 24, 2008 at 12:58:02AM +0200, Roel Kluin wrote: > Thanks to Joe Perches for catching an error in my previous Yep, that makes sense now.
> --- > asic->irq_nr is unsigned. platform_get_irq() may return signed unnoticed > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Acked-by: Samuel Ortiz <sameo@openedhand.com>
> --- > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c > index f6f2d96..abd7ffc 100644 > --- a/drivers/mfd/asic3.c > +++ b/drivers/mfd/asic3.c > @@ -300,10 +300,13 @@ static int asic3_irq_probe(struct platform_device *pdev) > struct asic3 *asic = platform_get_drvdata(pdev); > unsigned long clksel = 0; > unsigned int irq, irq_base; > + int ret; > + > + ret = platform_get_irq(pdev, 0); > + if (ret < 0) > + return ret; > > - asic->irq_nr = platform_get_irq(pdev, 0); > - if (asic->irq_nr < 0) > - return asic->irq_nr; > + asic->irq_nr = ret; > > /* turn on clock to IRQ controller */ > clksel |= CLOCK_SEL_CX; >
| |