Messages in this thread | | | From | Jesse Barnes <> | Subject | Re: [PATCH] PCI Express ASPM support should default to 'No' | Date | Wed, 23 Apr 2008 15:46:06 -0700 |
| |
On Tuesday, April 22, 2008 6:05 pm Shaohua Li wrote: > On Tue, 2008-04-22 at 17:12 -0700, Jesse Barnes wrote: > > On Tuesday, April 22, 2008 3:28 pm Jesper Juhl wrote: > > > Running 'make oldconfig' I just noticed that PCIEASPM defaults to > > > 'y' in Kconfig even though the feature is both experimental and the > > > help text recommends that if you are unsure you say 'n'. > > > It seems to me that this really should default to 'n', not 'y' at the > > > moment. > > > The following patch makes that change. Please consider applying. > > > > Seem reasonable, Shaohua? Please cc linux-pci on PCI patches > > though... > > Ok, I'm fine with the patch. Though by default, the policy is to use > BIOS setting, that is if BIOS disables ASPM, we don't enable it too.
Ok, pushed. Thanks Jesper & Shaohua.
Jesse
| |