Messages in this thread | | | From | Segher Boessenkool <> | Subject | Re: [PATCH 2/2] mpic_u3msi: mpic_u3msi: failed allocation unnoticed | Date | Thu, 24 Apr 2008 00:09:21 +0200 |
| |
> bitmap_find_free_region(), called by mpic_msi_alloc_hwirqs() may > return -ENOMEM, but hwirq of type irq_hw_number_t which is unsigned.
> list_for_each_entry(entry, &pdev->msi_list, list) { > hwirq = mpic_msi_alloc_hwirqs(msi_mpic, 1); > - if (hwirq < 0) { > + if (hwirq == -ENOMEM) { > pr_debug("u3msi: failed allocating hwirq\n"); > return hwirq; > }
Please test for _all_ error values, instead.
Segher
| |