lkml.org 
[lkml]   [2008]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Pull request for semaphore include changes
Date
 >  drivers/infiniband/core/user_mad.c            |    2 +-

Let me say up front I have no problem with this change, which moved from
<asm/semaphore.h> to <linux/semaphore.h>. So take this email as an
honest question and not any form of complaint or criticism. But looking
at that user_mad.c file in particular, I don't see any use of anything
that looks like it would come from semaphore.h.

So I'm wondering why you didn't just delete the inclusion, as you did in
other places? I can merge a follow-up that does that cleanup (which
builds and works fine on my usual architectures) but I want to avoid
breaking avr32 allyesconfig or something like that.

(Commit 2fe7e6f7 "IB/umad: Simplify and fix locking" changed the locking
scheme, so maybe you looked at an older file)

Thanks,
Roland


\
 
 \ /
  Last update: 2008-04-23 17:59    [W:0.050 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site