lkml.org 
[lkml]   [2008]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: PCI MSI breaks when booting with nosmp
Date
On Wednesday, April 23, 2008 7:38 am Jean Delvare wrote:
> > diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c
> > index e6abe8a..7cdf930 100644
> > --- a/arch/x86/kernel/smpboot.c
> > +++ b/arch/x86/kernel/smpboot.c
> > @@ -1138,14 +1138,10 @@ static int __init smp_sanity_check(unsigned
> > max_cpus) "forcing use of dummy APIC emulation.\n");
> > smpboot_clear_io_apic();
> > #ifdef CONFIG_X86_32
> > - if (nmi_watchdog == NMI_LOCAL_APIC) {
> > - printk(KERN_INFO "activating minimal APIC for"
> > - "NMI watchdog use.\n");
> > - connect_bsp_APIC();
> > - setup_local_APIC();
> > - end_local_APIC_setup();
> > - }
> > + connect_bsp_APIC();
> > #endif
> > + setup_local_APIC();
> > + end_local_APIC_setup();
> > return -1;
> > }
>
> Sorry for the late reply. I tested the patch above on top of 2.6.25-git4
> and yes, it fixes my problem: booting with "nosmp" works now. Thanks!
>
> Is this patch good enough to go upstream, and if so, through whose
> tree? Adding Thomas Gleixner to Cc.

Yeah I think the patch is reasonable, would be good to get feedback from
Thomas/Andi/Ingo though...

Jesse


\
 
 \ /
  Last update: 2008-04-23 17:15    [W:0.055 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site