lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [bisected] Latest git not seeing HD with sata_nv
Date
FWIW, the patch below also makes my box start working again...  I have
no idea what the right fix is, given that bug 3352 mostly seems to be
about nforce2 and nforce3, and my box has a more modern nvidia chipset:

00:04.0 IDE interface [0101]: nVidia Corporation MCP55 IDE [10de:036e] (rev a1)

Anyway, it seems 305d2a1a broke the logic that nv_hardreset() relies on
when it doesn't let sata_sff_hardreset() set class.

diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c
index 109b074..d0d85a3 100644
--- a/drivers/ata/sata_nv.c
+++ b/drivers/ata/sata_nv.c
@@ -1597,7 +1597,7 @@ static int nv_hardreset(struct ata_link *link, unsigned int *class,
* some controllers. Don't classify on hardreset. For more
* info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352
*/
- return sata_sff_hardreset(link, &dummy, deadline);
+ return sata_sff_hardreset(link, class, deadline);
}

static void nv_adma_error_handler(struct ata_port *ap)

\
 
 \ /
  Last update: 2008-04-23 03:41    [W:0.055 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site