Messages in this thread Patch in this message | | | From | Roland Dreier <> | Subject | Re: [bisected] Latest git not seeing HD with sata_nv | Date | Tue, 22 Apr 2008 18:38:36 -0700 |
| |
FWIW, the patch below also makes my box start working again... I have no idea what the right fix is, given that bug 3352 mostly seems to be about nforce2 and nforce3, and my box has a more modern nvidia chipset:
00:04.0 IDE interface [0101]: nVidia Corporation MCP55 IDE [10de:036e] (rev a1)
Anyway, it seems 305d2a1a broke the logic that nv_hardreset() relies on when it doesn't let sata_sff_hardreset() set class.
diff --git a/drivers/ata/sata_nv.c b/drivers/ata/sata_nv.c index 109b074..d0d85a3 100644 --- a/drivers/ata/sata_nv.c +++ b/drivers/ata/sata_nv.c @@ -1597,7 +1597,7 @@ static int nv_hardreset(struct ata_link *link, unsigned int *class, * some controllers. Don't classify on hardreset. For more * info, see http://bugzilla.kernel.org/show_bug.cgi?id=3352 */ - return sata_sff_hardreset(link, &dummy, deadline); + return sata_sff_hardreset(link, class, deadline); } static void nv_adma_error_handler(struct ata_port *ap)
| |