Messages in this thread | | | Date | Tue, 22 Apr 2008 19:28:49 -0500 | From | Jack Steiner <> | Subject | Re: [PATCH 01 of 12] Core of mmu notifiers |
| |
On Tue, Apr 22, 2008 at 06:07:27PM -0500, Robin Holt wrote: > > The only other change I did has been to move mmu_notifier_unregister > > at the end of the patchset after getting more questions about its > > reliability and I documented a bit the rmmod requirements for > > ->release. we'll think later if it makes sense to add it, nobody's > > using it anyway. > > XPMEM is using it. GRU will be as well (probably already does).
Yeppp.
The GRU driver unregisters the notifier when all GRU mappings are unmapped. I could make it work either way - either with or without an unregister function. However, unregister is the most logical action to take when all mappings have been destroyed.
--- jack
| |