lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 8/11] mips: convert to generic helpers for IPI function calls
On Tue, Apr 22, 2008 at 08:50:24PM +0200, Jens Axboe wrote:

> This converts mips to use the new helpers for smp_call_function() and
> friends, and adds support for smp_call_function_single(). Not tested,
> but it compiles.
>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
> ---
> arch/mips/Kconfig | 1 +
> arch/mips/kernel/smp-mt.c | 27 ++++++++-
> arch/mips/kernel/smp.c | 133 +++-------------------------------------
> arch/mips/kernel/smtc.c | 7 ++
> arch/mips/sibyte/bcm1480/smp.c | 3 +
> arch/mips/sibyte/sb1250/smp.c | 2 +
> include/asm-mips/smp.h | 12 +---
> 7 files changed, 49 insertions(+), 136 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 8724ed3..5092a9e 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -1742,6 +1742,7 @@ config SMP
> bool "Multi-Processing support"
> depends on SYS_SUPPORTS_SMP
> select IRQ_PER_CPU
> + select USE_GENERIC_SMP_HELPERS
> help
> This enables support for systems with more than one CPU. If you have
> a system with only one CPU, like most personal computers, say N. If
> diff --git a/arch/mips/kernel/smp-mt.c b/arch/mips/kernel/smp-mt.c
> index 89e6f6a..31049fc 100644
> --- a/arch/mips/kernel/smp-mt.c
> +++ b/arch/mips/kernel/smp-mt.c
> @@ -38,8 +38,9 @@
>
> #define MIPS_CPU_IPI_RESCHED_IRQ 0
> #define MIPS_CPU_IPI_CALL_IRQ 1
> +#define MIPS_CPU_IPI_CALL_SINGLE_IRQ 2

The smp-mt.c has no chance of working. There are only two hardware
interrupts available so just using one more won't quite work. But I like
the basic idea of this patch series.

Ralf


\
 
 \ /
  Last update: 2008-04-23 01:29    [W:0.174 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site