Messages in this thread | | | Date | Tue, 22 Apr 2008 16:20:45 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [git patch] free_irq() fixes |
| |
On Tue, 22 Apr 2008, Jeff Garzik wrote: > > (note, for mwave I couldn't use pSettings, since that might fail the ambiguity > test)
Ok, so using the pointer to inside a specific pSettings field is fine.
But can you also explain to me why that insane driver does this:
static irqreturn_t UartInterrupt(int irq, void *dev_id) { - int irqno = (int)(unsigned long) dev_id; + unsigned short *irqno = dev_id; ... *irqno, dev_id);
instead of just ignoring "dev_id" entirely, and then just using that "irq" argument directly?
Linus
| |