Messages in this thread | | | Date | Wed, 23 Apr 2008 09:08:35 +1000 | From | David Chinner <> | Subject | Re: [PATCH] xfs: remove unused params from functions in xfs/quota/* |
| |
On Tue, Apr 22, 2008 at 03:40:12PM +0200, Denys Vlasenko wrote: > Hi David, > > This patch deals with remaining cases of unused parameters in fs/xfs/quota/* > as far as I can see so far. The rest of unused parameters > in fs/xfs/quota/* cannot be easily eliminated due to addresses > of functions being taken.
I'd just kill the parameters to xfs_qm_hold_quotafs_ref and xfs_qm_rele_quotafs_ref and I wouldn't worry about removingthe debug-only id parameter to xfs_qm_dqread as it's not in a stack critical path.
Cheers,
Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group
| |