lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] xfs: remove unused params from functions in xfs/quota/*
    On Tue, Apr 22, 2008 at 03:40:12PM +0200, Denys Vlasenko wrote:
    > Hi David,
    >
    > This patch deals with remaining cases of unused parameters in fs/xfs/quota/*
    > as far as I can see so far. The rest of unused parameters
    > in fs/xfs/quota/* cannot be easily eliminated due to addresses
    > of functions being taken.

    I'd just kill the parameters to xfs_qm_hold_quotafs_ref and
    xfs_qm_rele_quotafs_ref and I wouldn't worry about removingthe debug-only
    id parameter to xfs_qm_dqread as it's not in a stack critical path.

    Cheers,

    Dave.
    --
    Dave Chinner
    Principal Engineer
    SGI Australian Software Group


    \
     
     \ /
      Last update: 2008-04-23 01:11    [W:8.289 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site