lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: #define out unused parameters for seven functions in xfs_trans.h
On Tue, Apr 22, 2008 at 01:51:03PM +0200, Denys Vlasenko wrote:
> [ resend: now with patch attached! :) ]
>
> Hi David,
>
> Seven xfs_trans_XXX functions declared in xfs_trans.h
> are not using "tp" parameter in non-debug builds,
> but it still takes stack space since these functions
> are not static and gcc cannot optimize it out.

Same as my last comments - I don't think the savings are
worth the additional clutter it introduces.

Cheers,

Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group


\
 
 \ /
  Last update: 2008-04-23 00:51    [W:0.177 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site