Messages in this thread | | | Date | Wed, 23 Apr 2008 08:47:21 +1000 | From | David Chinner <> | Subject | Re: [PATCH] xfs: #define out unused parameters for seven functions in xfs_trans.h |
| |
On Tue, Apr 22, 2008 at 01:51:03PM +0200, Denys Vlasenko wrote: > [ resend: now with patch attached! :) ] > > Hi David, > > Seven xfs_trans_XXX functions declared in xfs_trans.h > are not using "tp" parameter in non-debug builds, > but it still takes stack space since these functions > are not static and gcc cannot optimize it out.
Same as my last comments - I don't think the savings are worth the additional clutter it introduces.
Cheers,
Dave. -- Dave Chinner Principal Engineer SGI Australian Software Group
| |