lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] scc_pata: add ->dma_host_set and ->dma_start methods
Bartlomiej Zolnierkiewicz wrote:

> Add ->dma_host_set and ->dma_start methods (+ __scc_dma_end() helper)
> so scc_ide_{in,out}b() can be used directly.

In fact, you could have used in/out_be32() instead like the rest of the
code in this driver...

> There should be no functional changes caused by this patch.

> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>

Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> Index: b/drivers/ide/pci/scc_pata.c
> ===================================================================
> --- a/drivers/ide/pci/scc_pata.c
> +++ b/drivers/ide/pci/scc_pata.c
> @@ -260,6 +260,20 @@ static void scc_set_dma_mode(ide_drive_t
> out_be32((void __iomem *)udenvt_port, reg);
> }
>
> +static void scc_dma_host_set(ide_drive_t *drive, int on)
> +{
> + ide_hwif_t *hwif = drive->hwif;
> + u8 unit = (drive->select.b.unit & 0x01);

Needless parens.

> + u8 dma_stat = scc_ide_inb(hwif->dma_status);
> +
> + if (on)
> + dma_stat |= (1 << (5 + unit));

Again...

MBR, Sergei


\
 
 \ /
  Last update: 2008-04-22 18:31    [W:0.031 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site