Messages in this thread | | | Date | Tue, 22 Apr 2008 07:43:44 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: [PATCH 1/11] Add generic helpers for arch IPI function calls |
| |
On Tue, 22 Apr 2008, Jens Axboe wrote: > + > +static inline void csd_flag_wait(struct call_single_data *data) > +{ > + /* Wait for response */ > + do { > + /* > + * We need to see the flags store in the IPI handler > + */ > + smp_mb(); > + if (!(data->flags & CSD_FLAG_WAIT)) > + break; > + cpu_relax(); > + } while (1); > +}
You forgot to free the "data" here? The waiter must also free the object, since now the callee does not.
Linus
| |