lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/11] Add generic helpers for arch IPI function calls


    On Tue, 22 Apr 2008, Jens Axboe wrote:
    > +
    > +static inline void csd_flag_wait(struct call_single_data *data)
    > +{
    > + /* Wait for response */
    > + do {
    > + /*
    > + * We need to see the flags store in the IPI handler
    > + */
    > + smp_mb();
    > + if (!(data->flags & CSD_FLAG_WAIT))
    > + break;
    > + cpu_relax();
    > + } while (1);
    > +}

    You forgot to free the "data" here? The waiter must also free the object,
    since now the callee does not.

    Linus



    \
     
     \ /
      Last update: 2008-04-22 16:47    [W:4.023 / U:0.280 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site