Messages in this thread | | | Date | Tue, 22 Apr 2008 17:38:25 +0300 | From | Avi Kivity <> | Subject | Re: [PATCH 1/11] Add generic helpers for arch IPI function calls |
| |
Jens Axboe wrote: >> Introducing this fallback will make any usage from irq disabled context >> deadlock prone. >> >> I rather like the current interface. >> > > Hmm good point, I'll back that bit out again. >
But then you need to fix all callers to handle errors.
Perhaps we need a new flag for failable async IPIs (or better, API). I'm pretty sure no one uses s_c_f_s() from irq disabled context on x86, since it will WARN_ON(irqs_disabled()).
-- error compiling committee.c: too many arguments to function
| |