Messages in this thread | | | Date | Tue, 22 Apr 2008 12:55:56 +0200 | From | Takashi Iwai <> | Subject | Re: [PATCH 1/2] ALSA: Fix synchronize_irq() bugs, redundancies |
| |
At Mon, 21 Apr 2008 19:34:19 -0400, Jeff Garzik wrote: > > free_irq() calls synchronize_irq() for you, so there is no need for > drivers to manually do the same thing (again). Thus, calls where > sync-irq immediately precedes free-irq can be simplified. > > However, during this audit several bugs were noticed, where free-irq is > preceded by a "irq >= 0" check... but the sync-irq call is not covered > by the same check. > > So, where sync-irq could not be eliminated completely, the missing check > was added. > > Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Thanks, I applied to ALSA tree now.
Takashi
| |