lkml.org 
[lkml]   [2008]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0.01/1] hlist_for_each_entry_xxx: kill the "pos" argument
On 04/21, Paul E. McKenney wrote:
>
> On Mon, Apr 21, 2008 at 07:14:43PM +0400, Oleg Nesterov wrote:
> > (The actual patch is huge, 116K, I'll send it offline. This email contains
> > the chunk for list.h only).
> >
> > COMPILE TESTED ONLY (make allyesconfig).
> >
> > All hlist_for_each_entry_xxx() macros require the "pos" argument, which is not
> > actually needed and can be removed. See the changes in include/linux/list.h
> > (note that hlist_for_each_entry_safe() now does prefetch() too).
>
> Might it be better to do this in two
> phases to allow these patches to be applied incrementally?
>
> 1. Change all to "obsolete" __hlist_for_each_entry_xxx().
>
> 2. Incrementally change to hlist_for_each_entry_xxx(), removing
> the extra variable where possible.

Yes sure. Actually this was my initial plan.

Andrew, which way do you prefer? and should I wait for -rc1?

Oleg.



\
 
 \ /
  Last update: 2008-04-22 12:13    [W:0.439 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site