Messages in this thread | | | Date | Mon, 21 Apr 2008 22:18:24 -0500 | From | Eric Sandeen <> | Subject | Re: [PATCH] xfs: use smaller int param in call to xfs_flush_pages |
| |
Denys Vlasenko wrote: > Hi David, > > xfs_flush_pages() flags parameter is declared as uint64_t, but > code never pass values which do not fit into 32 bits. > All callsites sans one pass zero, and the last one passes > XFS_B_DELWRI, XFS_B_ASYNC or zero. > These values are defined in enum xfs_buf_flags_t and they > all fit in 32 bits. > > This patch changes type of the parameter and one variable > which used to pass it to unsigned int.
FWIW this one also seems to make no stack difference, at least on x86_64.
Not complaining; just checking it out. :)
If you can shink xfs_bmapi, let me know. :)
Thanks, -Eric
| |