Messages in this thread | | | Subject | Re: [PATCH 2/2] drivers/net: Fix synchronize_irq() bugs, redundancies | From | David Dillow <> | Date | Mon, 21 Apr 2008 21:04:42 -0400 |
| |
On Mon, 2008-04-21 at 19:35 -0400, Jeff Garzik wrote: > free_irq() calls synchronize_irq() for you, so there is no need for > drivers to manually do the same thing (again). Thus, calls where > sync-irq immediately precedes free-irq can be simplified.
> diff --git a/drivers/net/typhoon.c b/drivers/net/typhoon.c > index 333961b..7d2a4c6 100644 > --- a/drivers/net/typhoon.c > +++ b/drivers/net/typhoon.c [...] > /* Make sure there is no irq handler running on a different CPU. */ > - typhoon_synchronize_irq(dev->irq); > free_irq(dev->irq, dev);
Should probably kill the comment as well, since it was referring to the synchronize_irq() call.
Acked-by: Dave Dillow <dave@thedillows.org>
| |