Messages in this thread | | | Date | Mon, 21 Apr 2008 20:54:51 -0400 (EDT) | From | Steven Rostedt <> | Subject | Re: [PATCH] SELinux fixups needed for preemptable RCU from -rt |
| |
On Mon, 21 Apr 2008, Paul E. McKenney wrote: > @@ -807,8 +810,14 @@ int avc_ss_reset(u32 seqno) > > for (i = 0; i < AVC_CACHE_SLOTS; i++) { > spin_lock_irqsave(&avc_cache.slots_lock[i], flag); > + /* > + * On -rt the outer spinlock does not prevent RCU > + * from being performed:
I would suggest to change this comment to "With preemptible RCU" from "On -rt".
-- Steve
> + */ > + rcu_read_lock(); > list_for_each_entry(node, &avc_cache.slots[i], list) > avc_node_delete(node); > + rcu_read_unlock(); > spin_unlock_irqrestore(&avc_cache.slots_lock[i], flag); > } > 5A
| |