lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/5] IB/ehca: Prevent posting of SQ WQEs if QP not in RTS
Date
On Monday 21 April 2008 10:04, Joachim Fenkes wrote:

> + if (unlikely(my_qp->state != IB_QPS_RTS)) {
> + ehca_err(qp->device, "QP not in RTS state qpn=%x", qp->qp_num);
> + return -EINVAL;
> + }

Myself, I'm not very happy with using EINVAL, but I can't think of a more
fitting return code. Also, this is what nes, amso and cxgb3 return in such a
case; ipath posts an error CQE and mthca/mlx4 don't do this check at all
(AFAICS).

Better suggestions, anyone?

Regards,
Joachim



\
 
 \ /
  Last update: 2008-04-21 10:47    [W:0.052 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site