Messages in this thread | | | From | Joachim Fenkes <> | Subject | Re: [PATCH 1/5] IB/ehca: Prevent posting of SQ WQEs if QP not in RTS | Date | Mon, 21 Apr 2008 09:45:25 +0100 |
| |
On Monday 21 April 2008 10:04, Joachim Fenkes wrote:
> + if (unlikely(my_qp->state != IB_QPS_RTS)) { > + ehca_err(qp->device, "QP not in RTS state qpn=%x", qp->qp_num); > + return -EINVAL; > + }
Myself, I'm not very happy with using EINVAL, but I can't think of a more fitting return code. Also, this is what nes, amso and cxgb3 return in such a case; ipath posts an error CQE and mthca/mlx4 don't do this check at all (AFAICS).
Better suggestions, anyone?
Regards, Joachim
| |