Messages in this thread | | | Date | Tue, 22 Apr 2008 02:43:14 +0400 | From | Alexey Dobriyan <> | Subject | Re: [2.6 patch] fs/proc/kmsg.c should #include <linux/proc_fs.h> |
| |
On Tue, Apr 22, 2008 at 12:32:09AM +0300, Adrian Bunk wrote: > Every file should include the headers containing the externs its global > code.
Declaration should be moved to fs/proc/internal.h and included from there.
> --- a/fs/proc/kmsg.c > +++ b/fs/proc/kmsg.c > @@ -11,6 +11,7 @@ > #include <linux/kernel.h> > #include <linux/poll.h> > #include <linux/fs.h> > +#include <linux/proc_fs.h>
No, really. Such included tend to stick forever, so let's do right thing from beginning.
It would be nice if your scripts put at least some names of relevant globals into changelog.
| |