lkml.org 
[lkml]   [2008]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [git patches] minor irq handler cleanups
Russell King wrote:
> On Sun, Apr 20, 2008 at 09:35:51PM -0400, Jeff Garzik wrote:
>> diff --git a/arch/arm/mach-integrator/time.c b/arch/arm/mach-integrator/time.c
>> index 5278f58..5235f64 100644
>> --- a/arch/arm/mach-integrator/time.c
>> +++ b/arch/arm/mach-integrator/time.c
>> @@ -125,7 +125,7 @@ static int rtc_probe(struct amba_device *dev, void *id)
>> xtime.tv_sec = __raw_readl(rtc_base + RTC_DR);
>>
>> ret = request_irq(dev->irq[0], arm_rtc_interrupt, IRQF_DISABLED,
>> - "rtc-pl030", dev);
>> + "rtc-pl030", NULL);
>> if (ret)
>> goto map_out;
>>
>
> BTW, if you're removing the dev_id argument from request_irq(), that
> also needs to happen for the corresponding free_irq() calls.
> arch/arm/mach-integrator/time.c does:
>
> free_irq(dev->irq[0], dev);
>
> and these are untouched.

hrm, good point. I re-reviewed specifically for this issue, just now,
and it looks like there is another case of this as well, outside ARM.

If this hasn't been pulled, I'll redo the commit, otherwise I'll fix.

Jeff





\
 
 \ /
  Last update: 2008-04-21 10:21    [W:0.057 / U:0.700 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site