Messages in this thread | | | Subject | Re: [PATCH 1/2] OLPC: Add support for calling into Open Firmware | From | David Woodhouse <> | Date | Mon, 21 Apr 2008 21:25:17 +0100 |
| |
On Mon, 2008-04-21 at 15:46 -0400, Andres Salomon wrote: > Well, no, it wasn't already working; that's the reason this whole > thread started. It was crashing someone's machine. That's why the OFW > interface, as imperfect as it is, is an _improvement_.
You're proposing a new interface between bootloader and kernel as a temporary hack just to work around that until we fix it properly?
That seems like overkill to me. I'd just go for is_geode() as you suggested, and maybe PCI configuration tricks to detect the lack of VSA so we can be _fairly_ sure it's OLPC before we poke at it?
Or why not try '!page_is_ram(0xffffffc0 >> PAGE_SHIFT)' if it's just to avoid that particular warning? :)
-- dwmw2
| |