Messages in this thread | | | Date | Mon, 21 Apr 2008 15:24:00 -0500 | From | Jason Wessel <> | Subject | Re: [PATCH] kgdb: fix signedness mixmatches, add statics, add declaration to header |
| |
Harvey Harrison wrote: > Noticed by sparse: > arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static? > kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static? > kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static? > kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static? > > Related to kgdb_hex2long: > arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 (different signedness) > arch/x86/kernel/kgdb.c:371:28: expected long *long_val > arch/x86/kernel/kgdb.c:371:28: got unsigned long *<noident> > kernel/kgdb.c:469:27: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:469:27: expected long *long_val > kernel/kgdb.c:469:27: got unsigned long *<noident> > kernel/kgdb.c:470:27: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:470:27: expected long *long_val > kernel/kgdb.c:470:27: got unsigned long *<noident> > kernel/kgdb.c:894:27: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:894:27: expected long *long_val > kernel/kgdb.c:894:27: got unsigned long *<noident> > kernel/kgdb.c:895:27: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:895:27: expected long *long_val > kernel/kgdb.c:895:27: got unsigned long *<noident> > kernel/kgdb.c:1127:28: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:1127:28: expected long *long_val > kernel/kgdb.c:1127:28: got unsigned long *<noident> > kernel/kgdb.c:1132:25: warning: incorrect type in argument 2 (different signedness) > kernel/kgdb.c:1132:25: expected long *long_val > kernel/kgdb.c:1132:25: got unsigned long *<noident> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> >
This patch looked fine Harvey, I queued it for the next pull request at:
http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=shortlog;h=for_linus
Jason.
| |