Messages in this thread | | | From | kamezawa.hiroyu@jp ... | Date | Mon, 21 Apr 2008 22:02:24 +0900 (JST) | Subject | Re: Re: [PATCH]Fix usemap for DISCONTIG/FLATMEM with not-aligned zone initilaization. |
| |
thank you for review.
>> + z = page_zone(page); > >Does this have to be recalculated for every page? The function name >"memmap_init_zone" suggests it could be done just once (but I'm on >unfamiliar territory here, ignore any nonsense from me). > you're right. I will consider this again.
>> - if ((pfn & (pageblock_nr_pages-1))) >> + if ((z->zone_start_pfn < pfn) > >Shouldn't that be <= ? > yes.
>> + && (pfn < z->zone_start_pfn + z->spanned_pages) >> + && !(pfn & (pageblock_nr_pages-1))) > >Ah, that line (with the ! in) makes more sense than what was there >before; but that's an unrelated (minor) bugfix which you ought to >mention separately in the change comment. > Ah, ok. I'll rewrite and post again. thank you.
-Kame
| |