Messages in this thread | | | Date | Sun, 20 Apr 2008 16:09:27 +0200 | From | Stefan Richter <> | Subject | Re: [GIT PATCH] SCSI updates for 2.6.25 |
| |
Matthew Wilcox wrote: > --- a/Documentation/kbuild/kconfig-language.txt > +++ b/Documentation/kbuild/kconfig-language.txt > @@ -104,9 +104,9 @@ applicable everywhere (see syntax). > Reverse dependencies can only be used with boolean or tristate > symbols. > Note: > - select is evil.... select will by brute force set a symbol > - equal to 'y' without visiting the dependencies. So abusing > - select you are able to select a symbol FOO even if FOO depends > + select should be used with care. It can set a symbol > + without visiting the dependencies. By abusing select you are > + able to select a symbol FOO even if FOO depends > on BAR that is not set. In general use select only for > non-visible symbols (no prompts anywhere) and for symbols with > no dependencies. That will limit the usefulness but on the
"It can set a symbol without visiting the dependencies." = imprecise
"select will by brute force set a symbol [...] without visiting the dependencies." = clear. So why not leave this portion of the text as it is.
Maybe change "equal to 'y'" to "equal to 'y' or 'm'" or to "" to make it entirely correct. -- Stefan Richter -=====-==--- -=-- =-=-- http://arcgraph.de/sr/
| |