Messages in this thread | | | Date | Wed, 2 Apr 2008 03:26:24 -0700 | From | "Paul Menage" <> | Subject | Re: [PATCH -mm 2/3] cgroup: simplify init_subsys() |
| |
On Tue, Apr 1, 2008 at 7:16 PM, Li Zefan <lizf@cn.fujitsu.com> wrote: > - > - /* If this subsystem requested that it be notified with fork > - * events, we should send it one now for every process in the > - * system */ > - if (ss->fork) { > - struct task_struct *g, *p; > - > - read_lock(&tasklist_lock); > - do_each_thread(g, p) { > - ss->fork(ss, p); > - } while_each_thread(g, p); > - read_unlock(&tasklist_lock); > - }
Should we maybe call ss->fork(ss, &init_task) ? Or just document that ss->fork() explicitly doesn't get called for init.
Maybe also add some BUG()s to confirm that no other tasks have in fact been forked by this point?
Paul
| |