Messages in this thread | | | Date | Thu, 3 Apr 2008 03:55:46 +0100 | From | Al Viro <> | Subject | Re: [PATCH 7/7] asm-generic: suppress sparse warning in ioctl.h |
| |
On Wed, Apr 02, 2008 at 07:51:08PM -0700, Linus Torvalds wrote: > > > On Thu, 3 Apr 2008, Al Viro wrote: > > > > Um... But that's _not_ a link-time constant - simply an int variable not > > defined in any object file... > > Ahh, you're right, my bad. We could change it to take the address of it, > though. I assume gcc is happy with that too?
gcc might be, but what are you going to do with it? Expression is an integer one, after all - in cases that had triggered that thread it was used (after & 0xff) as array index.
Besides, logically it's _not_ a constant at all - not even a base + constant, after using it in such expression...
| |