lkml.org 
[lkml]   [2008]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iwlwifi/Kconfg: make IWLWIFI_LEDS invisible
On Wed, Apr 2, 2008 at 7:10 PM, John W. Linville <linville@tuxdriver.com> wrote:
> Select IWLWIFI_LEDS automatically when either IWL3945_LEDS or
> IWL4965_LEDS is selected. This avoids potential misconfigurations
> which lead to build failures for iwl-led.c.
>
> Cc: Miles Lane <miles.lane@gmail.com>
> Cc: reinette.chatre@intel.com
> Signed-off-by: John w. Linville <linville@tuxdriver.com>
> ---
> drivers/net/wireless/iwlwifi/Kconfig | 11 +++++------
> 1 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig
> index 4a5c8c0..8137690 100644
> --- a/drivers/net/wireless/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/iwlwifi/Kconfig
> @@ -3,11 +3,8 @@ config IWLCORE
> depends on PCI && MAC80211 && WLAN_80211 && EXPERIMENTAL
>
> config IWLWIFI_LEDS
> - bool "Enable LEDS features in iwlwifi driver"
> - depends on IWLCORE && MAC80211_LEDS && LEDS_CLASS
> - ---help---
> - This option enables LEDS for the iwlwifi drivers
> -
> + bool
> + default n
>
> config IWLCORE_RFKILL
> boolean "IWLWIFI RF kill support"
> @@ -52,7 +49,8 @@ config IWL4965_HT
>
> config IWL4965_LEDS
> bool "Enable LEDS features in iwl4965 driver"
> - depends on IWL4965 && IWLWIFI_LEDS
> + depends on IWL4965 && MAC80211_LEDS && LEDS_CLASS
> + select IWLWIFI_LEDS
> ---help---
> This option enables LEDS for the iwlwifi drivers
>
> @@ -137,6 +135,7 @@ config IWL3945_SPECTRUM_MEASUREMENT
> config IWL3945_LEDS
> bool "Enable LEDS features in iwl3945 driver"
> depends on IWL3945 && MAC80211_LEDS && LEDS_CLASS
> + select IWLWIFI_LEDS

3945 is for now not dependent at all on this flag.
Otherwise looks OK


\
 
 \ /
  Last update: 2008-04-02 22:21    [W:0.051 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site