Messages in this thread | | | Subject | Re: [PATCH RFC] hotplug-memory: refactor online_pages to separate zone growth from page onlining | From | Dave Hansen <> | Date | Wed, 02 Apr 2008 11:59:52 -0700 |
| |
On Wed, 2008-04-02 at 11:52 -0700, Jeremy Fitzhardinge wrote: > > Why don't we just have hotplug work that way? When we want to take a > > guest from 1GB to 1GB+1 page (or whatever), we just hotplug the entire > > section (512MB or 1GB or whatever), actually online the whole thing, > > then make the balloon driver take it back to where it *should* be. That > > way we're completely reusing existing components that have do be able to > > handle this case anyway. > > > > Yeah, this is suboptimal, an it has a possibility of fragmenting the > > memory, but it will only be used for the x86-32 case. > > > > It also requires you actually have the memory on hand to populate the > whole area. 512MB is still a significant chunk on a 2GB server; you may > end up generating significant overall system memory pressure to scrape > together the memory, only to immediately discard it again.
That's a very good point. Can we make it so that the hypervisors don't actually allocate the memory to the guest until its first touch? If the pages are on the freelist, their *contents* shouldn't be touched at all during the onlining process.
Maybe we could put a special mark on the pages (please no page flag :) and the allocator can jump in and ask for the page from the hypervisor before returning it to the system. I think Anthony had some ideas around this area. It's kinda a poor man's page hinting.
-- Dave
| |