lkml.org 
[lkml]   [2008]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/3] hugetlbfs: architecture header cleanup
From
Date

On Wed, 2008-04-02 at 16:26 +0200, Gerald Schaefer wrote:
>
> include/asm-ia64/hugetlb.h | 21 +++++++++++++++++++
> include/asm-ia64/page.h | 6 -----
> include/asm-powerpc/hugetlb.h | 35 +++++++++++++++++++++++++++++++
> include/asm-powerpc/page_64.h | 7 ------
> include/asm-sh/hugetlb.h | 28 +++++++++++++++++++++++++
> include/asm-sparc64/hugetlb.h | 30 +++++++++++++++++++++++++++
> include/asm-sparc64/page.h | 2 -
> include/asm-x86/hugetlb.h | 28 +++++++++++++++++++++++++
> include/linux/hugetlb.h | 46 ------------------------------------------

The way I read this, you took some arch-independent bits, like
prepare_hugepage_range(), and copied them to several architectures. How
is this a cleanup? Can they really not share common code?

-- Dave



\
 
 \ /
  Last update: 2008-04-02 19:45    [W:0.093 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site