lkml.org 
[lkml]   [2008]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [bug] build failure in net/netfilter/nf_conntrack_sip.c, on latest -git

* David Miller <davem@davemloft.net> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Date: Sat, 19 Apr 2008 12:00:35 +0200
>
> [ netfilter-devel and netdev added to CC: ]
>
> > randconfig testing found a netfilter build failure in latest -git:
> >
> > net/netfilter/nf_conntrack_sip.c: In function 'set_expected_rtp_rtcp':
> > net/netfilter/nf_conntrack_sip.c:786: error: 'struct nf_conntrack_expect' has no member named 'saved_ip'
> >
> > http://redhat.com/~mingo/misc/config-Sat_Apr_19_11_37_02_CEST_2008.bad
> >
> > disabling CONFIG_NF_CONNTRACK_SIP works it around.
>
> I think this will fix it.
>
> Patrick, is this how we should do it?
>
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index c1fc0f1..fd60b2b 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -245,7 +245,7 @@ config NF_CONNTRACK_SANE
>
> config NF_CONNTRACK_SIP
> tristate "SIP protocol support"
> - depends on NF_CONNTRACK
> + depends on NF_CONNTRACK && NF_NAT
> default m if NETFILTER_ADVANCED=n
> help
> SIP is an application-layer control protocol that can establish,

thanks David, this solves the build failure here.

Tested-by: Ingo Molnar <mingo@elte.hu>

Ingo



\
 
 \ /
  Last update: 2008-04-19 12:45    [W:1.568 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site