Messages in this thread | | | Date | Sat, 19 Apr 2008 01:10:29 -0300 | From | Henrique de Moraes Holschuh <> | Subject | Re: [patch 3/3] ThinkPad ACPI: fix possible NULL pointer dereference |
| |
On Fri, 18 Apr 2008, Cyrill Gorcunov wrote: > Oh, I see what do you mean - you mean that even if machine is ThinkPad > *but* kstrdup failed with my patch it would lead that the machine will > *not* be recognized as ThinkPad and that is not correct, agreed. But how
That's acceptable. It is not worth bothering with this failure mode at that point of the driver lifetime. Your patch makes it just keep running, which is fine since if it can't kstrdup a small string, it will abend with -ENOMEM soon enough when it tries to alocate other much bigger structures.
Just in case, I will schedule a low-priority fix for later that will -ENOMEM if kstrdup fails, but your patch is good enough a fix for now.
-- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh
| |