Messages in this thread | | | Date | Sat, 19 Apr 2008 00:38:07 -0600 | From | Alex Chiang <> | Subject | Re: 2.6.25-rc8-mm1 panic in rpaphp_register_slot() |
| |
Hi Ben,
* Benjamin Herrenschmidt <benh@kernel.crashing.org>: > > > The basic idea, which I keep botching on pSeries, is that when we > > make a call to pci_hp_register, we now need to pass it: > > > > pci_hp_register(struct hotplug_slot *slot, struct pci_bus *bus, int slot_nr) > > > > I am having trouble figuring out the slot_nr argument. Basically, > > I want to get the devfn of the slot we're looking at. > > I haven't looked in details yet, but I can already tell that things on > pSeries aren't that simple because we don't necessarily know in advance > about "slots"... > > When you add a physical PCI device to a partition, things can range from: > > - A device gets added to an existing bridge (ie. slot) > - A whole P2P brigde gets added with that device below it (that's a slot too) > - A whole PCI host bridge gets added with that device below it (or with > a P2P bridge below it and the device below that). > > In the later case, it's hard to have any concept of slot since you don't > know anything about the host bridge before it gets added to your partition :-) > > So I'm not sure how much we can use of your slot infrastructure, I'll have > to look, I suspect it can cover some cases but not all of them.
*poke*
Any update on this?
Anything I can do to help?
> On Wed, 2008-04-16 at 13:03 -0700, Andrew Morton wrote: > > > > fwiw, http://userweb.kernel.org/~akpm/bh.gz (agains -rc9) contains all > > of > > -mm up to and including > > pci-hotplug-acpi-pci-slot-detection-driver.patch > > and is suitable for review/repair/etc. > > Ok, I'll use that.
Thanks,
/ac
| |