Messages in this thread | | | Date | Sat, 19 Apr 2008 12:16:34 -0400 | From | Alan Cox <> | Subject | Re: [PATCH 05/15] drivers/char: minor irq handler cleanups |
| |
On Fri, Apr 18, 2008 at 07:22:51PM -0400, Jeff Garzik wrote: > +++ b/drivers/char/cyclades.c > if (unlikely(!ISZLOADED(*cinfo))) { > #ifdef CY_DEBUG_INTERRUPTS > - printk(KERN_DEBUG "cyz_interrupt: board not yet loaded " > - "(IRQ%d).\n", irq); > + printk(KERN_DEBUG "cyz_interrupt: board not yet loaded\n");
If you are debugging IRQ funnies you really really want to know which IRQ or which port.
Ack the rest on the base the __foo_interrupt uglies will go away with the final change over. A follow up patch to tweak cyclades would be useful and also to know from Andrew if these are going in so they don't clash with the coding style cleanups also queued.
| |