Messages in this thread | | | From | Roland Dreier <> | Subject | Re: [ofa-general] Re: [GIT PULL] please pull infiniband.git | Date | Sat, 19 Apr 2008 09:12:06 -0700 |
| |
> | > drivers/built-in.o: In function `ipath_init_one': > | > ipath_driver.c:(.devinit.text+0x1e5bc): undefined reference to `ipath_init_iba7220_funcs' > > Yes, that issue should be fixed. Our preference was to not build > if it wouldn't work. We'd have to add the conditional check at > the function setup routines.
Not sure I really follow this response... ipath_driver.c has
case PCI_DEVICE_ID_INFINIPATH_7220: #ifndef CONFIG_PCI_MSI ipath_dbg("CONFIG_PCI_MSI is not enabled, " "using IntX for unit %u\n", dd->ipath_unit); #endif ipath_init_iba7220_funcs(dd); break;
so clearly ipath_init_iba7220_funcs() was intended to be built and used even if CONFIG_PCI_MSI was not defined. From the code it looks like all should work fine if PCI_MSI is not set, so I don't know what you mean about conditional checks.
(BTW since I'm looking at this code, "IntX" should probably be capitalized as "INTx" to match what the PCI specs say)
- R.
| |