Messages in this thread Patch in this message | | | Date | Fri, 18 Apr 2008 14:50:06 -0600 | From | Bjorn Helgaas <> | Subject | [patch 11/53] PNPACPI: pnpacpi_encode_ext_irq() wrongly set "irq" instead of "extended_irq" |
| |
pnpacpi_encode_ext_irq() should set resource->data.extended_irq, not resource->data.irq.
This has been wrong since at least 2.6.12. I haven't seen any bug reports, but it's clearly incorrect.
Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Index: work8/drivers/pnp/pnpacpi/rsparser.c =================================================================== --- work8.orig/drivers/pnp/pnpacpi/rsparser.c 2008-04-10 12:26:08.000000000 -0600 +++ work8/drivers/pnp/pnpacpi/rsparser.c 2008-04-10 13:26:19.000000000 -0600 @@ -818,9 +818,9 @@ resource->data.extended_irq.triggering = triggering; resource->data.extended_irq.polarity = polarity; if (triggering == ACPI_EDGE_SENSITIVE) - resource->data.irq.sharable = ACPI_EXCLUSIVE; + resource->data.extended_irq.sharable = ACPI_EXCLUSIVE; else - resource->data.irq.sharable = ACPI_SHARED; + resource->data.extended_irq.sharable = ACPI_SHARED; resource->data.extended_irq.interrupt_count = 1; resource->data.extended_irq.interrupts[0] = p->start; } --
| |