Messages in this thread | | | From | Paul Moore <> | Subject | Re: 2.6.25-mm1: not looking good | Date | Fri, 18 Apr 2008 10:57:12 -0400 |
| |
On Thursday 17 April 2008 9:35:38 pm Andrew Morton wrote: > I dropped git-selinux and that crash seems to have gone away. It > took about five minutes before, but would presumably have happened > earlier if I'd reduced the cache size. > > btw, wouldn't this > > --- a/security/selinux/netnode.c~a > +++ a/security/selinux/netnode.c > @@ -190,7 +190,7 @@ static int sel_netnode_insert(struct sel > if (sel_netnode_hash[idx].size == SEL_NETNODE_HASH_BKT_LIMIT) { > struct sel_netnode *tail; > tail = list_entry(node->list.prev, struct sel_netnode, list); > - list_del_rcu(node->list.prev); > + list_del_rcu(&tail->list); > call_rcu(&tail->rcu, sel_netnode_free); > } else > sel_netnode_hash[idx].size++; > _ > > be a bit clearer? If it's correct - I didn't try too hard :)
Looks good to me, although before I fix this let me try and figure out why this code is causing the machine to puke all over itself. Priorities you know :)
-- paul moore linux @ hp
| |