Messages in this thread | | | Date | Fri, 18 Apr 2008 03:44:26 -0700 | From | Andrew Morton <> | Subject | Re: [RFC PATCH 1/2] Marker probes in futex.c |
| |
On Tue, 15 Apr 2008 14:02:22 +0200 Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Tue, 2008-04-15 at 17:23 +0530, K. Prasad wrote: > > > + trace_mark(futex_wait_called, "uaddr:%p fshared:%p val:%u " > > + "abs_time:%p bitset:%d", > > + uaddr, fshared, val, abs_time, bitset); > > This is some seriuosly ugly looking gunk, why would we want stuff like > that scattered across the code?
My 2c: if we even begin to countenance merging stuff like that, it's time for all the trace code to be removed.
<checks the email headers>
Nope, it wasn't April 1st. Guys, get a grip.
| |