lkml.org 
[lkml]   [2008]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v2.6.26] what's brewing in x86.git for v2.6.26
On Thu, 17 Apr 2008 10:45:59 +0300 "Pekka Enberg" <penberg@cs.helsinki.fi> wrote:

> On Thu, Apr 17, 2008 at 10:25 AM, Andrew Morton
> <akpm@linux-foundation.org> wrote:
> > > Soren Sandmann (1):
> > > x86: add the debugfs interface for the sysprof tool
> >
> > Also, I (and apparently only I) actually reviewed the implementation and
> > found it to be riddled with bugs and shortcomings. afacit this was
> > completely ignored and you propose to merge it anwyay?
>
> No, I fixed some of those and I think Ingo/Soren did the rest. But it
> needs another round of review on LKML for sure.

afaict none of my review comments have been addressed in the sysprof.c which
is in -mm. It has the following commits:

x86, sysprof: merge header to compilation unit
x86, sysprof: clean up stack frame copying
x86, sysprof: remove dead code
sysprof: user pointer verification
sysprof: minor cleanups
x86: add the debugfs interface for the sysprof tool

I received no email even acknowledging the review comments.


\
 
 \ /
  Last update: 2008-04-17 10:23    [W:0.128 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site