Messages in this thread Patch in this message | | | Date | Thu, 17 Apr 2008 06:16:24 +0200 | From | Roel Kluin <> | Subject | [PATCH] mos7840: test and propagate set_uart_reg return value |
| |
The test for an mos7840_set_uart_reg() error return value only works when status is signed. propagate its error value.
Signed-off-by: Roel Kluin <12o3l@tiscali.nl> ---
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index aeeb9cb..ef1ede2 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -1713,7 +1713,7 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file, { struct moschip_port *mos7840_port; unsigned int mcr; - unsigned int status; + int status; dbg("%s - port %d", __FUNCTION__, port->number); @@ -1739,11 +1739,10 @@ static int mos7840_tiocmset(struct usb_serial_port *port, struct file *file, mos7840_port->shadowMCR = mcr; - status = 0; status = mos7840_set_uart_reg(port, MODEM_CONTROL_REGISTER, mcr); if (status < 0) { dbg("setting MODEM_CONTROL_REGISTER Failed\n"); - return -1; + return status; } return 0;
| |