Messages in this thread | | | Date | Thu, 17 Apr 2008 21:39:18 +0200 | From | "Vegard Nossum" <> | Subject | Re: [v2.6.26] what's brewing in x86.git for v2.6.26 |
| |
On Thu, Apr 17, 2008 at 9:35 PM, Ingo Molnar <mingo@elte.hu> wrote: > > * Ingo Molnar <mingo@elte.hu> wrote: > > > > > Actually it doesn't. I attach a patch which gets rid of the page flag, > > > and we rely instead on the PTE flag for page-trackedness. > > [...] > > > Ingo, will you take this for some additional testing? > > > > thanks Vegard, i've applied it - looks good to me too. > > x86.git randconfig testing found a build bug - fix below. > > Ingo >
Oh, oops. Of course... Thanks, you shouldn't have had to do that :-(
Vegard
> ------------> > Subject: kmemcheck: fix build > From: Ingo Molnar <mingo@elte.hu> > Date: Thu Apr 17 21:20:43 CEST 2008 > > Signed-off-by: Ingo Molnar <mingo@elte.hu> > --- > include/linux/kmemcheck.h | 3 +++ > 1 file changed, 3 insertions(+) > > Index: linux/include/linux/kmemcheck.h > =================================================================== > --- linux.orig/include/linux/kmemcheck.h > +++ linux/include/linux/kmemcheck.h > @@ -1,6 +1,8 @@ > #ifndef LINUX_KMEMCHECK_H > #define LINUX_KMEMCHECK_H > > +#include <linux/types.h> > + > #ifdef CONFIG_KMEMCHECK > extern int kmemcheck_enabled; > > @@ -24,6 +26,7 @@ void kmemcheck_mark_uninitialized_pages( > #ifndef CONFIG_KMEMCHECK > #define kmemcheck_enabled 0 > static inline void kmemcheck_init(void) { } > +static inline bool kmemcheck_page_is_tracked(struct page *p) { return false; } > #endif /* CONFIG_KMEMCHECK */ > > #endif /* LINUX_KMEMCHECK_H */ >
-- "The animistic metaphor of the bug that maliciously sneaked in while the programmer was not looking is intellectually dishonest as it disguises that the error is the programmer's own creation." -- E. W. Dijkstra, EWD1036
| |