Messages in this thread | | | Subject | Re: [PATCH] NET: catch signed nla_len() retval in tcf_simp_init() | From | jamal <> | Date | Thu, 17 Apr 2008 08:58:33 -0400 |
| |
On Thu, 2008-17-04 at 06:55 +0200, Patrick McHardy wrote:
> The change is also unnecessary because the attribute was > already validated and the length can not be less than zero.
Since act_simple is an academic example: I think that a better solution is to add TCA_DEF_DATA (which is a string) to the nla_policy. nla_policy is defined but at the moment it is not used in the call to nla_parse_nested() - might as well use it.
Roel, would you like to take a crack at that? You will need to define the max size of the string that TCA_DEF_DATA can hold (if you want to do it cleanly then define it in include/linux/tc_act/tc_defact.h). This MAX size will appear in the nla_policy.
cheers, jamal
| |